diff options
| author |   Ondrej Mosnacek <omosnace@redhat.com> | 2022-05-17 14:08:16 +0200 |
|---|---|---|
| committer |   Paul Moore <paul@paul-moore.com> | 2022-05-17 18:34:35 -0400 |
| commit | 6254bd3db316c9ccb3b05caa8b438be63245466f (patch) | |
| tree | ccbc625604a64e01eafc773a0c3fa7f66df6e14a /security/selinux/ss/hashtab.c | |
| parent | Linux 5.18-rc7 (diff) | |
| download | linux-dev-6254bd3db316c9ccb3b05caa8b438be63245466f.tar.xz linux-dev-6254bd3db316c9ccb3b05caa8b438be63245466f.zip | |
selinux: fix bad cleanup on error in hashtab_duplicate()
The code attempts to free the 'new' pointer using kmem_cache_free(),
which is wrong because this function isn't responsible of freeing it.
Instead, the function should free new->htable and clear the contents of
*new (to prevent double-free).
Cc: stable@vger.kernel.org
Fixes: c7c556f1e81b ("selinux: refactor changing booleans")
Reported-by: Wander Lairson Costa <wander@redhat.com>
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security/selinux/ss/hashtab.c')
| -rw-r--r-- | security/selinux/ss/hashtab.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c index 0ae4e4e57a40..3fb8f9026e9b 100644 --- a/security/selinux/ss/hashtab.c +++ b/security/selinux/ss/hashtab.c @@ -179,7 +179,8 @@ int hashtab_duplicate(struct hashtab *new, struct hashtab *orig, kmem_cache_free(hashtab_node_cachep, cur); } } - kmem_cache_free(hashtab_node_cachep, new); + kfree(new->htable); + memset(new, 0, sizeof(*new)); return -ENOMEM; } |