diff options
| author |   Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> | 2021-04-12 22:45:50 +0900 |
|---|---|---|
| committer |   Casey Schaufler <casey@schaufler-ca.com> | 2021-05-10 13:55:08 -0700 |
| commit | 49ec114a6e62d8d320037ce71c1aaf9650b3cafd (patch) | |
| tree | 9026cbc37cf4c0c23f100109ef9c3fc574a30467 /security/smack | |
| parent | security/smack/: fix misspellings using codespell tool (diff) | |
| download | linux-dev-49ec114a6e62d8d320037ce71c1aaf9650b3cafd.tar.xz linux-dev-49ec114a6e62d8d320037ce71c1aaf9650b3cafd.zip | |
smackfs: restrict bytes count in smk_set_cipso()
Oops, I failed to update subject line.
From 07571157c91b98ce1a4aa70967531e64b78e8346 Mon Sep 17 00:00:00 2001
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: Mon, 12 Apr 2021 22:25:06 +0900
Subject: [PATCH] smackfs: restrict bytes count in smk_set_cipso()
Commit 7ef4c19d245f3dc2 ("smackfs: restrict bytes count in smackfs write
functions") missed that count > SMK_CIPSOMAX check applies to only
format == SMK_FIXED24_FMT case.
Reported-by: syzbot <syzbot+77c53db50c9fff774e8e@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Diffstat (limited to 'security/smack')
| -rw-r--r-- | security/smack/smackfs.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 66f3c539d504..3a75d2a8f517 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c @@ -855,6 +855,8 @@ static ssize_t smk_set_cipso(struct file *file, const char __user *buf, if (format == SMK_FIXED24_FMT && (count < SMK_CIPSOMIN || count > SMK_CIPSOMAX)) return -EINVAL; + if (count > PAGE_SIZE) + return -EINVAL; data = memdup_user_nul(buf, count); if (IS_ERR(data)) |