diff options
| author |   Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> | 2021-10-19 20:54:31 +0900 |
|---|---|---|
| committer |   Casey Schaufler <casey@schaufler-ca.com> | 2021-10-22 08:46:44 -0700 |
| commit | f91488ee15bd3cac467e2d6a361fc2d34d1052ae (patch) | |
| tree | 7264fbc8c247a06cbb987c4bc5f50ec45cb7c604 /security/smack | |
| parent | Smack: fix W=1 build warnings (diff) | |
| download | linux-dev-f91488ee15bd3cac467e2d6a361fc2d34d1052ae.tar.xz linux-dev-f91488ee15bd3cac467e2d6a361fc2d34d1052ae.zip | |
smackfs: use __GFP_NOFAIL for smk_cipso_doi()
syzbot is reporting kernel panic at smk_cipso_doi() due to memory
allocation fault injection [1]. The reason for need to use panic() was
not explained. But since no fix was proposed for 18 months, for now
let's use __GFP_NOFAIL for utilizing syzbot resource on other bugs.
Link: https://syzkaller.appspot.com/bug?extid=89731ccb6fec15ce1c22 [1]
Reported-by: syzbot <syzbot+89731ccb6fec15ce1c22@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Diffstat (limited to 'security/smack')
| -rw-r--r-- | security/smack/smackfs.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 9d853c0e55b8..89989d28ffc5 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c @@ -693,9 +693,7 @@ static void smk_cipso_doi(void) printk(KERN_WARNING "%s:%d remove rc = %d\n", __func__, __LINE__, rc); - doip = kmalloc(sizeof(struct cipso_v4_doi), GFP_KERNEL); - if (doip == NULL) - panic("smack: Failed to initialize cipso DOI.\n"); + doip = kmalloc(sizeof(struct cipso_v4_doi), GFP_KERNEL | __GFP_NOFAIL); doip->map.std = NULL; doip->doi = smk_cipso_doi_value; doip->type = CIPSO_V4_MAP_PASS; |