diff options
| author |   Eric Dumazet <edumazet@google.com> | 2018-09-27 09:31:59 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-09-28 11:12:29 -0700 |
| commit | 9447a10ff607debe5e30cc438fb56925a559b9d9 (patch) | |
| tree | 4c613ed3dfd53a10c2592d10e168e1366d4f4a27 /security | |
| parent | net: ena: remove ndo_poll_controller (diff) | |
| download | linux-dev-9447a10ff607debe5e30cc438fb56925a559b9d9.tar.xz linux-dev-9447a10ff607debe5e30cc438fb56925a559b9d9.zip | |
sfc: remove ndo_poll_controller
As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.
sfc uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Edward Cree <ecree@solarflare.com>
Cc: Bert Kenward <bkenward@solarflare.com>
Cc: Solarflare linux maintainers <linux-net-drivers@solarflare.com>
Acked-By: Bert Kenward <bkenward@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions