aboutsummaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorVladyslav Tarasiuk <vladyslavt@mellanox.com>2019-12-06 13:51:05 +0000
committerDavid S. Miller <davem@davemloft.net>2019-12-06 11:58:45 -0800
commit9f104c7736904ac72385bbb48669e0c923ca879b (patch)
tree7b1ea2418814ac3fdeafca6b51a5f191d6de6d0d /security
parentnet: stmmac: reset Tx desc base address before restarting Tx (diff)
downloadlinux-dev-9f104c7736904ac72385bbb48669e0c923ca879b.tar.xz
linux-dev-9f104c7736904ac72385bbb48669e0c923ca879b.zip
mqprio: Fix out-of-bounds access in mqprio_dump
When user runs a command like tc qdisc add dev eth1 root mqprio KASAN stack-out-of-bounds warning is emitted. Currently, NLA_ALIGN macro used in mqprio_dump provides too large buffer size as argument for nla_put and memcpy down the call stack. The flow looks like this: 1. nla_put expects exact object size as an argument; 2. Later it provides this size to memcpy; 3. To calculate correct padding for SKB, nla_put applies NLA_ALIGN macro itself. Therefore, NLA_ALIGN should not be applied to the nla_put parameter. Otherwise it will lead to out-of-bounds memory access in memcpy. Fixes: 4e8b86c06269 ("mqprio: Introduce new hardware offload mode and shaper in mqprio") Signed-off-by: Vladyslav Tarasiuk <vladyslavt@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions