diff options
| author |   John Johansen <john.johansen@canonical.com> | 2015-12-16 18:09:10 -0800 |
|---|---|---|
| committer | John Johansen <john.johansen@canonical.com> | 2016-07-12 08:43:10 -0700 |
| commit | de7c4cc947f9f56f61520ee7edaf380434a98c8d (patch) | |
| tree | 8da638b921498bba5fca1fc2b4192166f45700ef /security | |
| parent | apparmor: fix ref count leak when profile sha1 hash is read (diff) | |
| download | linux-dev-de7c4cc947f9f56f61520ee7edaf380434a98c8d.tar.xz linux-dev-de7c4cc947f9f56f61520ee7edaf380434a98c8d.zip | |
apparmor: fix refcount race when finding a child profile
When finding a child profile via an rcu critical section, the profile
may be put and scheduled for deletion after the child is found but
before its refcount is incremented.
Protect against this by repeating the lookup if the profiles refcount
is 0 and is one its way to deletion.
Signed-off-by: John Johansen <john.johansen@canonical.com>
Acked-by: Seth Arnold <seth.arnold@canonical.com>
Diffstat (limited to 'security')
| -rw-r--r-- | security/apparmor/policy.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c index ca402d028db8..780712553651 100644 --- a/security/apparmor/policy.c +++ b/security/apparmor/policy.c @@ -766,7 +766,9 @@ struct aa_profile *aa_find_child(struct aa_profile *parent, const char *name) struct aa_profile *profile; rcu_read_lock(); - profile = aa_get_profile(__find_child(&parent->base.profiles, name)); + do { + profile = __find_child(&parent->base.profiles, name); + } while (profile && !aa_get_profile_not0(profile)); rcu_read_unlock(); /* refcount released by caller */ |