aboutsummaryrefslogtreecommitdiffstats
path: root/sound/ac97_bus.c
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2018-01-10 23:48:05 +0100
committerTakashi Iwai <tiwai@suse.de>2018-01-11 00:01:26 +0100
commit23b19b7b50fe1867da8d431eea9cd3e4b6328c2c (patch)
treeb0423568a0157908dd2ea19badf8e0e74cd7ca7b /sound/ac97_bus.c
parentALSA: hda - Apply the existing quirk to iMac 14,1 (diff)
downloadlinux-dev-23b19b7b50fe1867da8d431eea9cd3e4b6328c2c.tar.xz
linux-dev-23b19b7b50fe1867da8d431eea9cd3e4b6328c2c.zip
ALSA: pcm: Remove yet superfluous WARN_ON()
muldiv32() contains a snd_BUG_ON() (which is morphed as WARN_ON() with debug option) for checking the case of 0 / 0. This would be helpful if this happens only as a logical error; however, since the hw refine is performed with any data set provided by user, the inconsistent values that can trigger such a condition might be passed easily. Actually, syzbot caught this by passing some zero'ed old hw_params ioctl. So, having snd_BUG_ON() there is simply superfluous and rather harmful to give unnecessary confusions. Let's get rid of it. Reported-by: syzbot+7e6ee55011deeebce15d@syzkaller.appspotmail.com Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/ac97_bus.c')
0 files changed, 0 insertions, 0 deletions