diff options
| author |   Pavel Skripkin <paskripkin@gmail.com> | 2021-10-24 17:03:15 +0300 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2021-10-26 07:59:40 +0200 |
| commit | 3ab7992018455ac63c33e9b3eaa7264e293e40f4 (patch) | |
| tree | f2d9dc3b2b27a8bdfa6b597d05717f20c0d2450b /sound/core/oss | |
| parent | ALSA: hda/realtek: Fix mic mute LED for the HP Spectre x360 14 (diff) | |
| download | linux-dev-3ab7992018455ac63c33e9b3eaa7264e293e40f4.tar.xz linux-dev-3ab7992018455ac63c33e9b3eaa7264e293e40f4.zip | |
ALSA: mixer: fix deadlock in snd_mixer_oss_set_volume
In commit 411cef6adfb3 ("ALSA: mixer: oss: Fix racy access to slots")
added mutex protection in snd_mixer_oss_set_volume(). Second
mutex_lock() in same function looks like typo, fix it.
Reported-by: syzbot+ace149a75a9a0a399ac7@syzkaller.appspotmail.com
Fixes: 411cef6adfb3 ("ALSA: mixer: oss: Fix racy access to slots")
Cc: <stable@vger.kernel.org>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Link: https://lore.kernel.org/r/20211024140315.16704-1-paskripkin@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core/oss')
| -rw-r--r-- | sound/core/oss/mixer_oss.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c index d5ddc154a735..9620115cfdc0 100644 --- a/sound/core/oss/mixer_oss.c +++ b/sound/core/oss/mixer_oss.c @@ -313,7 +313,7 @@ static int snd_mixer_oss_set_volume(struct snd_mixer_oss_file *fmixer, pslot->volume[1] = right; result = (left & 0xff) | ((right & 0xff) << 8); unlock: - mutex_lock(&mixer->reg_mutex); + mutex_unlock(&mixer->reg_mutex); return result; } |