diff options
| author |   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2020-09-02 16:21:32 -0500 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2020-09-03 09:27:56 +0200 |
| commit | e408ab068aeca958b83bb6e5ca724356f8c7d78e (patch) | |
| tree | f281c7b75cce6fb253f34e3ca61f0e8d1b1a1114 /sound/drivers | |
| parent | ALSA: vx: vx_core: clarify operator precedence (diff) | |
| download | linux-dev-e408ab068aeca958b83bb6e5ca724356f8c7d78e.tar.xz linux-dev-e408ab068aeca958b83bb6e5ca724356f8c7d78e.zip | |
ALSA: vx: vx_pcm: remove redundant assignment
Fix cppcheck warning:
sound/drivers/vx/vx_pcm.c:539:30: style: Variable
'chip->playback_pipes[audio]' is reassigned a value before the old one
has been used. [redundantAssignment]
chip->playback_pipes[audio] = pipe;
^
sound/drivers/vx/vx_pcm.c:533:31: note: chip->playback_pipes[audio] is
assigned
chip->playback_pipes[audio] = pipe;
^
sound/drivers/vx/vx_pcm.c:539:30: note: chip->playback_pipes[audio] is
overwritten
chip->playback_pipes[audio] = pipe;
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200902212133.30964-18-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/drivers')
| -rw-r--r-- | sound/drivers/vx/vx_pcm.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sound/drivers/vx/vx_pcm.c b/sound/drivers/vx/vx_pcm.c index 664b9efa9a50..47361e26be80 100644 --- a/sound/drivers/vx/vx_pcm.c +++ b/sound/drivers/vx/vx_pcm.c @@ -530,7 +530,6 @@ static int vx_pcm_playback_open(struct snd_pcm_substream *subs) err = vx_alloc_pipe(chip, 0, audio, 2, &pipe); /* stereo playback */ if (err < 0) return err; - chip->playback_pipes[audio] = pipe; } /* open for playback */ pipe->references++; |