aboutsummaryrefslogtreecommitdiffstats
path: root/sound/pci/echoaudio
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2020-07-13 13:53:24 +0300
committerTakashi Iwai <tiwai@suse.de>2020-07-13 18:04:48 +0200
commitb91c9cb9d4b378fda65c3196034ecd09ee1493ef (patch)
treea61d9234b015fcda485205e66d0a642aac1f9d2e /sound/pci/echoaudio
parentALSA: line6: add hw monitor volume control for POD HD500 (diff)
downloadlinux-dev-b91c9cb9d4b378fda65c3196034ecd09ee1493ef.tar.xz
linux-dev-b91c9cb9d4b378fda65c3196034ecd09ee1493ef.zip
ALSA: echoaudio: re-enable IRQs on failure path
This should be spin_unlock_irq() instead of spin_lock(). Fixes: 6c3312544873 ("ALSA: echoaudio: Prevent races in calls to set_audio_format()") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20200713105324.GB251988@mwanda Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/echoaudio')
-rw-r--r--sound/pci/echoaudio/echoaudio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index e81f42811f45..6aeb99aa2414 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -721,7 +721,7 @@ static int pcm_prepare(struct snd_pcm_substream *substream)
spin_lock_irq(&chip->lock);
if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index))) {
- spin_unlock(&chip->lock);
+ spin_unlock_irq(&chip->lock);
return -EINVAL;
}