diff options
| author |   David Henningsson <david.henningsson@canonical.com> | 2012-09-07 07:25:44 +0200 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2012-09-07 12:41:38 +0200 |
| commit | 5fe8e1e6717c0ed40abff8be3a441d0e2eb47169 (patch) | |
| tree | f736e9ea99a691e0df5f169f36ae586fd19291f2 /sound/pci/hda/hda_jack.c | |
| parent | ALSA: control: Fix missing VOLATILE flag at creating controls (diff) | |
| download | linux-dev-5fe8e1e6717c0ed40abff8be3a441d0e2eb47169.tar.xz linux-dev-5fe8e1e6717c0ed40abff8be3a441d0e2eb47169.zip | |
ALSA: hda - Remove ignore_misc_bit
The purpose of this flag is unclear. If the problem is that some machines
have broken misc/NO_PRESENCE bits, they should be fixed by pin fixups.
In addition, this causes jack detection functionality to be flawed on
the M31EI, where there are two jacks without jack detection (which is
properly marked as NO_PRESENCE), but due to ignore_misc_bit, these
jacks are instead being reported as being present but always unplugged.
BugLink: https://bugs.launchpad.net/bugs/939161
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/hda/hda_jack.c')
| -rw-r--r-- | sound/pci/hda/hda_jack.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sound/pci/hda/hda_jack.c b/sound/pci/hda/hda_jack.c index aaccc0236bda..c9333c9688fb 100644 --- a/sound/pci/hda/hda_jack.c +++ b/sound/pci/hda/hda_jack.c @@ -26,9 +26,8 @@ bool is_jack_detectable(struct hda_codec *codec, hda_nid_t nid) return false; if (!(snd_hda_query_pin_caps(codec, nid) & AC_PINCAP_PRES_DETECT)) return false; - if (!codec->ignore_misc_bit && - (get_defcfg_misc(snd_hda_codec_get_pincfg(codec, nid)) & - AC_DEFCFG_MISC_NO_PRESENCE)) + if (get_defcfg_misc(snd_hda_codec_get_pincfg(codec, nid)) & + AC_DEFCFG_MISC_NO_PRESENCE) return false; if (!(get_wcaps(codec, nid) & AC_WCAP_UNSOL_CAP)) return false; |