diff options
| author |   Libin Yang <libin.yang@linux.intel.com> | 2016-06-16 11:13:25 +0800 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2016-06-16 10:10:12 +0200 |
| commit | 960a581e22d93a784db843110ad1e6249c1542a5 (patch) | |
| tree | 749416a468c7b815232ec33ac3de403953a7e74e /sound/pci/hda/patch_hdmi.c | |
| parent | ALSA: seq_oss: Change structure initialisation to C99 style (diff) | |
| download | linux-dev-960a581e22d93a784db843110ad1e6249c1542a5.tar.xz linux-dev-960a581e22d93a784db843110ad1e6249c1542a5.zip | |
ALSA: hda: fix some klockwork scan warnings
This patch fixes some warnings from klockwork.
These warnings are not the real issues. The patch
adds the sanity check.
Signed-off-by: Libin Yang <libin.yang@linux.intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/hda/patch_hdmi.c')
| -rw-r--r-- | sound/pci/hda/patch_hdmi.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index d0d5ad8beac5..56e5204ac9c1 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1680,6 +1680,11 @@ static bool check_non_pcm_per_cvt(struct hda_codec *codec, hda_nid_t cvt_nid) mutex_lock(&codec->spdif_mutex); spdif = snd_hda_spdif_out_of_nid(codec, cvt_nid); + /* Add sanity check to pass klockwork check. + * This should never happen. + */ + if (WARN_ON(spdif == NULL)) + return true; non_pcm = !!(spdif->status & IEC958_AES0_NONAUDIO); mutex_unlock(&codec->spdif_mutex); return non_pcm; |