diff options
| author |   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2022-08-22 20:42:36 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-08-31 12:13:01 +0100 |
| commit | 43265ceeb0b9cb1f8f5fb182adaa6c2ed4941478 (patch) | |
| tree | 57e201c54e20a2bf973ef2a8362716b3eef4f401 /sound/soc/codecs/wcd-mbhc-v2.c | |
| parent | ASoC: hdmi-codec: remove unused definitions (diff) | |
| download | linux-dev-43265ceeb0b9cb1f8f5fb182adaa6c2ed4941478.tar.xz linux-dev-43265ceeb0b9cb1f8f5fb182adaa6c2ed4941478.zip | |
ASoC: wcd-mbhc-v2: remove always-true condition
cppcheck warning:
'cross_conn<0' is always true [knownConditionTrueFalse]
} else if (cross_conn < 0) /* Error */
^
'!cross_conn' is not redundant
} else if (!cross_conn) { /* no cross connection */
^
is always true
} else if (cross_conn < 0) /* Error */
^
sound/soc/codecs/wcd-mbhc-v2.c:1192:26: style: Condition
sound/soc/codecs/wcd-mbhc-v2.c:1188:15: note: Assuming that condition
sound/soc/codecs/wcd-mbhc-v2.c:1192:26: note: Condition 'cross_conn<0'
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Chao Song <chao.song@intel.com>
Link: https://lore.kernel.org/r/20220822184239.169757-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/wcd-mbhc-v2.c')
| -rw-r--r-- | sound/soc/codecs/wcd-mbhc-v2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/wcd-mbhc-v2.c b/sound/soc/codecs/wcd-mbhc-v2.c index 98baef594bf3..b16a18dbfe7a 100644 --- a/sound/soc/codecs/wcd-mbhc-v2.c +++ b/sound/soc/codecs/wcd-mbhc-v2.c @@ -1189,7 +1189,7 @@ correct_plug_type: pt_gnd_mic_swap_cnt = 0; plug_type = wcd_mbhc_get_plug_from_adc(mbhc, output_mv); continue; - } else if (cross_conn < 0) /* Error */ + } else /* Error if (cross_conn < 0) */ continue; if (pt_gnd_mic_swap_cnt == GND_MIC_SWAP_THRESHOLD) { |