diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2015-10-13 10:08:57 +0300 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2015-10-22 13:55:23 +0100 |
| commit | 523bade22428d4c6742dd7bfb4c0259a23bb9ec3 (patch) | |
| tree | 84aa6e771e4617a27ecbe6612c56f40bb9349907 /sound/soc/codecs/wm8731.c | |
| parent | Linux 4.3-rc1 (diff) | |
| download | linux-dev-523bade22428d4c6742dd7bfb4c0259a23bb9ec3.tar.xz linux-dev-523bade22428d4c6742dd7bfb4c0259a23bb9ec3.zip | |
ASoC: wm8731: harmless underflow in wm8731_put_deemph()
The code tries to verify that "deemph" is zero or one, but it fails to
account for that it can be negative. It's harmless because negatives
are treated the same as one, but we should fix it just to silence the
static checker warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/wm8731.c')
| -rw-r--r-- | sound/soc/codecs/wm8731.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index ace8645245a0..07cf1bd7913a 100644 --- a/sound/soc/codecs/wm8731.c +++ b/sound/soc/codecs/wm8731.c @@ -132,7 +132,7 @@ static int wm8731_put_deemph(struct snd_kcontrol *kcontrol, { struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec); - int deemph = ucontrol->value.integer.value[0]; + unsigned int deemph = ucontrol->value.integer.value[0]; int ret = 0; if (deemph > 1) |