diff options
| author |   Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-07-04 09:18:33 -0500 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2018-07-05 11:07:59 +0100 |
| commit | b999a7a9e72bd2d37b5d03772cedfc4dd45875bf (patch) | |
| tree | bda601c8b833faf563cc2a40b733c0ac217c09c2 /sound/soc/fsl/fsl_spdif.c | |
| parent | ASoC: qdsp6: q6afe-dai: Do not overwrite slim dai num_channels (diff) | |
| download | linux-dev-b999a7a9e72bd2d37b5d03772cedfc4dd45875bf.tar.xz linux-dev-b999a7a9e72bd2d37b5d03772cedfc4dd45875bf.zip | |
ASoC: fsl_spdif: Use 64-bit arithmetic instead of 32-bit
Add suffix ULL to constant 64 in order to give the compiler complete
information about the proper arithmetic to use.
Notice that such constant is used in a context that expects an
expression of type u64 (64 bits, unsigned) and the following
expression is currently being evaluated using 32-bit arithmetic:
rate[index] * txclk_df * 64
Addresses-Coverity-ID: 1222129 ("Unintentional integer overflow")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/fsl/fsl_spdif.c')
| -rw-r--r-- | sound/soc/fsl/fsl_spdif.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 9b59d87b61bf..740b90df44bb 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -1118,7 +1118,7 @@ static u32 fsl_spdif_txclk_caldiv(struct fsl_spdif_priv *spdif_priv, for (sysclk_df = sysclk_dfmin; sysclk_df <= sysclk_dfmax; sysclk_df++) { for (txclk_df = 1; txclk_df <= 128; txclk_df++) { - rate_ideal = rate[index] * txclk_df * 64; + rate_ideal = rate[index] * txclk_df * 64ULL; if (round) rate_actual = clk_round_rate(clk, rate_ideal); else |