diff options
| author |   Daniel Mack <daniel@zonque.org> | 2014-10-19 09:07:36 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2014-10-22 11:38:01 +0100 |
| commit | 6aa256b6c680245b4c402f2c8a8ee356f03df3ea (patch) | |
| tree | cb8faa364e6f8406173ee1abc486198af9d1104f /sound/soc/fsl | |
| parent | Linux 3.18-rc1 (diff) | |
| download | linux-dev-6aa256b6c680245b4c402f2c8a8ee356f03df3ea.tar.xz linux-dev-6aa256b6c680245b4c402f2c8a8ee356f03df3ea.zip | |
ASoC: fsl: use strncpy() to prevent copying of over-long names
Use strncpy() instead of strcpy(). That's not a security issue, as the
source buffer is taken from DT nodes, but we should still enforce bound
checks. Spotted by Coverity.
Signed-off-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/fsl')
| -rw-r--r-- | sound/soc/fsl/fsl_asrc.c | 2 | ||||
| -rw-r--r-- | sound/soc/fsl/fsl_esai.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 3b145313f93e..ed866e9a2928 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -792,7 +792,7 @@ static int fsl_asrc_probe(struct platform_device *pdev) return -ENOMEM; asrc_priv->pdev = pdev; - strcpy(asrc_priv->name, np->name); + strncpy(asrc_priv->name, np->name, sizeof(asrc_priv->name) - 1); /* Get the addresses and IRQ */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 8bcdfda09d7a..a645e296199e 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -734,7 +734,7 @@ static int fsl_esai_probe(struct platform_device *pdev) return -ENOMEM; esai_priv->pdev = pdev; - strcpy(esai_priv->name, np->name); + strncpy(esai_priv->name, np->name, sizeof(esai_priv->name) - 1); /* Get the addresses and IRQ */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |