diff options
| author |   Amadeusz Sławiński <amadeuszx.slawinski@intel.com> | 2019-08-27 16:17:08 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2019-08-27 19:23:50 +0100 |
| commit | 810f3b860850148788fc1ed8a6f5f807199fed65 (patch) | |
| tree | ba8b92ee26239edf1eb0f139ddb8da153e0392e0 /sound/soc/intel/common | |
| parent | ASoC: Intel: Skylake: Use correct function to access iomem space (diff) | |
| download | linux-dev-810f3b860850148788fc1ed8a6f5f807199fed65.tar.xz linux-dev-810f3b860850148788fc1ed8a6f5f807199fed65.zip | |
ASoC: Intel: Fix use of potentially uninitialized variable
If ipc->ops.reply_msg_match is NULL, we may end up using uninitialized
mask value.
reported by smatch:
sound/soc/intel/common/sst-ipc.c:266 sst_ipc_reply_find_msg() error: uninitialized symbol 'mask'.
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@intel.com>
Link: https://lore.kernel.org/r/20190827141712.21015-3-amadeuszx.slawinski@linux.intel.com
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Diffstat (limited to 'sound/soc/intel/common')
| -rw-r--r-- | sound/soc/intel/common/sst-ipc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/soc/intel/common/sst-ipc.c b/sound/soc/intel/common/sst-ipc.c index ef5b66af1cd2..3a66121ee9bb 100644 --- a/sound/soc/intel/common/sst-ipc.c +++ b/sound/soc/intel/common/sst-ipc.c @@ -222,6 +222,8 @@ struct ipc_message *sst_ipc_reply_find_msg(struct sst_generic_ipc *ipc, if (ipc->ops.reply_msg_match != NULL) header = ipc->ops.reply_msg_match(header, &mask); + else + mask = (u64)-1; if (list_empty(&ipc->rx_list)) { dev_err(ipc->dev, "error: rx list empty but received 0x%llx\n", |