diff options
| author |   Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2021-10-06 14:06:43 +0300 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2021-10-07 15:45:39 +0100 |
| commit | f8c3ec4368df1e5051030beaeb961fd7f625d2d1 (patch) | |
| tree | 9c89cb682e6399056868819048b14213417a345d /sound/soc/sof | |
| parent | ASoC: SOF: core: Clean up snd_sof_get_status() prints (diff) | |
| download | linux-dev-f8c3ec4368df1e5051030beaeb961fd7f625d2d1.tar.xz linux-dev-f8c3ec4368df1e5051030beaeb961fd7f625d2d1.zip | |
ASoC: SOF: loader: Drop SOF_DBG_DUMP_REGS flag when firmware start fails
snd_sof_dsp_run() failure indicates that the DSP did not even booted up,
thus asking for dumping registers at this point is not valid.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20211006110645.26679-18-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/sof')
| -rw-r--r-- | sound/soc/sof/loader.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/soc/sof/loader.c b/sound/soc/sof/loader.c index b06f5cded066..c0aa9a5d1494 100644 --- a/sound/soc/sof/loader.c +++ b/sound/soc/sof/loader.c @@ -820,8 +820,7 @@ int snd_sof_run_firmware(struct snd_sof_dev *sdev) ret = snd_sof_dsp_run(sdev); if (ret < 0) { dev_err(sdev->dev, "error: failed to start DSP\n"); - snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX | - SOF_DBG_DUMP_PCI); + snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_MBOX | SOF_DBG_DUMP_PCI); return ret; } |