diff options
| author |   Subhransu S. Prusty <subhransu.s.prusty@intel.com> | 2017-08-23 19:37:12 +0530 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2017-08-23 16:50:21 +0100 |
| commit | 9149916f1e8c912c585ddebf12a98e99bd81aafe (patch) | |
| tree | b3ed3a6c0985dd2a29ba9dbbcdbdb898ee782486 /sound/soc | |
| parent | ASoC: Intel: Skylake: Fix DSP core ref count for init failure (diff) | |
| download | linux-dev-9149916f1e8c912c585ddebf12a98e99bd81aafe.tar.xz linux-dev-9149916f1e8c912c585ddebf12a98e99bd81aafe.zip | |
ASoC: Intel: Skylake: Fix uninitialized return
On failure to get dsp_ops, dsp_init returns error without assigning ret. ret
is assigned in code path which will never be executed. Fix it.
Fixes: f77d443c4c29 ("ASoC: Intel: Skylake: Fix to free resources for dsp_init failure"
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc')
| -rw-r--r-- | sound/soc/intel/skylake/skl-messages.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c index f0f11f597b21..697d07bc1b5a 100644 --- a/sound/soc/intel/skylake/skl-messages.c +++ b/sound/soc/intel/skylake/skl-messages.c @@ -278,8 +278,8 @@ int skl_init_dsp(struct skl *skl) ops = skl_get_dsp_ops(skl->pci->device); if (!ops) { - goto unmap_mmio; ret = -EIO; + goto unmap_mmio; } loader_ops = ops->loader_ops(); |