diff options
| author |   Mark Brown <broonie@kernel.org> | 2022-09-20 22:32:24 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-09-20 22:32:24 +0100 |
| commit | a65eacaf98503e03b9a23ab12f836c71baaf9ead (patch) | |
| tree | 89332f730a0e77e0118ced84ee3a2b1d5110512f /sound/soc | |
| parent | ASoC: SOF: sof-audio: fix prepare/unprepare (diff) | |
| parent | ASoC: SOF: ipc4-topology: remove useless assignment (diff) | |
| download | linux-dev-a65eacaf98503e03b9a23ab12f836c71baaf9ead.tar.xz linux-dev-a65eacaf98503e03b9a23ab12f836c71baaf9ead.zip | |
ASoC: SOF: ipc4-topology: minor cleanup
Merge series from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>:
Two updates on warnings reported by cppcheck.
Diffstat (limited to 'sound/soc')
| -rw-r--r-- | sound/soc/sof/ipc4-topology.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index 64929dc9af39..66bbe101680c 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -331,7 +331,7 @@ static int sof_ipc4_widget_setup_msg(struct snd_sof_widget *swidget, struct sof_ msg->extension = SOF_IPC4_MOD_EXT_PPL_ID(swidget->pipeline_id); msg->extension |= SOF_IPC4_MOD_EXT_CORE_ID(swidget->core); - type = fw_module->man4_module_entry.type & SOF_IPC4_MODULE_DP ? 1 : 0; + type = (fw_module->man4_module_entry.type & SOF_IPC4_MODULE_DP) ? 1 : 0; msg->extension |= SOF_IPC4_MOD_EXT_DOMAIN(type); return 0; @@ -1447,7 +1447,6 @@ static int sof_ipc4_control_setup(struct snd_sof_dev *sdev, struct snd_sof_contr static int sof_ipc4_widget_setup(struct snd_sof_dev *sdev, struct snd_sof_widget *swidget) { - struct snd_sof_widget *pipe_widget = swidget->pipe_widget; struct sof_ipc4_pipeline *pipeline; struct sof_ipc4_msg *msg; void *ipc_data = NULL; @@ -1530,7 +1529,7 @@ static int sof_ipc4_widget_setup(struct snd_sof_dev *sdev, struct snd_sof_widget swidget->widget->name); return ret; } - pipeline = pipe_widget->private; + msg->primary &= ~SOF_IPC4_MOD_INSTANCE_MASK; msg->primary |= SOF_IPC4_MOD_INSTANCE(swidget->instance_id); |