diff options
| author |   Takashi Iwai <tiwai@suse.de> | 2020-12-18 15:58:58 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2020-12-18 17:08:24 +0100 |
| commit | 9df28edce7c6ab38050235f6f8b43dd7ccd01b6d (patch) | |
| tree | 9df877e6ddcd9eaf8601974a9d19636e1db1b6be /sound/usb | |
| parent | ALSA: pcm: Remove snd_pcm_lib_preallocate_dma_free() (diff) | |
| download | linux-dev-9df28edce7c6ab38050235f6f8b43dd7ccd01b6d.tar.xz linux-dev-9df28edce7c6ab38050235f6f8b43dd7ccd01b6d.zip | |
ALSA: usb-audio: Disable sample read check if firmware doesn't give back
Some buggy firmware don't give the current sample rate but leaves
zero. Handle this case more gracefully without warning but just skip
the current rate verification from the next time.
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20201218145858.2357-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb')
| -rw-r--r-- | sound/usb/clock.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/sound/usb/clock.c b/sound/usb/clock.c index e940dcee792b..31051f2be46d 100644 --- a/sound/usb/clock.c +++ b/sound/usb/clock.c @@ -534,6 +534,12 @@ static int set_sample_rate_v1(struct snd_usb_audio *chip, } crate = data[0] | (data[1] << 8) | (data[2] << 16); + if (!crate) { + dev_info(&dev->dev, "failed to read current rate; disabling the check\n"); + chip->sample_rate_read_error = 3; /* three strikes, see above */ + return 0; + } + if (crate != rate) { dev_warn(&dev->dev, "current rate %d is different from the runtime rate %d\n", crate, rate); // runtime->rate = crate; |