diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2019-07-05 10:57:04 +0100 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2019-07-05 12:10:36 +0200 |
| commit | 388b00f045180179fedff4b108d40a0192684cda (patch) | |
| tree | 3ecff19e480475752be356b542587eeee4e78d4f /sound | |
| parent | ALSA: asihpi: Remove unneeded variable change (diff) | |
| download | linux-dev-388b00f045180179fedff4b108d40a0192684cda.tar.xz linux-dev-388b00f045180179fedff4b108d40a0192684cda.zip | |
ALSA: cs4281: remove redundant assignment to variable val and remove a goto
The variable val is being assigned with a value that is never
read and it is being updated later with a new value. The
assignment is redundant and can be removed. Also remove a
goto statement and a label and replace with a break statement.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/pci/cs4281.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sound/pci/cs4281.c b/sound/pci/cs4281.c index 15bbf9564c82..d271cb881948 100644 --- a/sound/pci/cs4281.c +++ b/sound/pci/cs4281.c @@ -709,7 +709,7 @@ static int snd_cs4281_trigger(struct snd_pcm_substream *substream, int cmd) static unsigned int snd_cs4281_rate(unsigned int rate, unsigned int *real_rate) { - unsigned int val = ~0; + unsigned int val; if (real_rate) *real_rate = rate; @@ -722,9 +722,8 @@ static unsigned int snd_cs4281_rate(unsigned int rate, unsigned int *real_rate) case 44100: return 1; case 48000: return 0; default: - goto __variable; + break; } - __variable: val = 1536000 / rate; if (real_rate) *real_rate = 1536000 / val; |