diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2018-03-27 16:07:52 +0300 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2018-03-27 15:20:19 +0200 |
| commit | 5607dddbfca774fb38bffadcb077fe03aa4ac5c6 (patch) | |
| tree | 9401e09e47c8398b1c9d302399fe339161cda506 /sound | |
| parent | ALSA: pcm: Use dma_bytes as size parameter in dma_mmap_coherent() (diff) | |
| download | linux-dev-5607dddbfca774fb38bffadcb077fe03aa4ac5c6.tar.xz linux-dev-5607dddbfca774fb38bffadcb077fe03aa4ac5c6.zip | |
ALSA: pcm: potential uninitialized return values
Smatch complains that "tmp" can be uninitialized if we do a zero size
write.
Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/core/oss/pcm_oss.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c index 02298c9c6020..441405081195 100644 --- a/sound/core/oss/pcm_oss.c +++ b/sound/core/oss/pcm_oss.c @@ -1326,7 +1326,7 @@ static ssize_t snd_pcm_oss_write2(struct snd_pcm_substream *substream, const cha static ssize_t snd_pcm_oss_write1(struct snd_pcm_substream *substream, const char __user *buf, size_t bytes) { size_t xfer = 0; - ssize_t tmp; + ssize_t tmp = 0; struct snd_pcm_runtime *runtime = substream->runtime; if (atomic_read(&substream->mmap_count)) @@ -1433,7 +1433,7 @@ static ssize_t snd_pcm_oss_read2(struct snd_pcm_substream *substream, char *buf, static ssize_t snd_pcm_oss_read1(struct snd_pcm_substream *substream, char __user *buf, size_t bytes) { size_t xfer = 0; - ssize_t tmp; + ssize_t tmp = 0; struct snd_pcm_runtime *runtime = substream->runtime; if (atomic_read(&substream->mmap_count)) |