aboutsummaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorYang Guang <yang.guang5@zte.com.cn>2021-12-18 09:54:16 +0800
committerTakashi Iwai <tiwai@suse.de>2021-12-25 09:14:19 +0100
commit5dcdc4600c3a7773a7b901d6b7eb29340be95cf6 (patch)
tree1ccaa610706047799b0045e3c9a69082b9053bf3 /sound
parentkselftest: alsa: Validate values read from enumerations (diff)
downloadlinux-dev-5dcdc4600c3a7773a7b901d6b7eb29340be95cf6.tar.xz
linux-dev-5dcdc4600c3a7773a7b901d6b7eb29340be95cf6.zip
ALSA: hda: use swap() to make code cleaner
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid opencoding it. Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: David Yang <davidcomponentone@gmail.com> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn> Link: https://lore.kernel.org/r/ebc9db44b802dfc88e1538629b517e000acb27b3.1639790796.git.yang.guang5@zte.com.cn Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r--sound/pci/hda/hda_auto_parser.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c
index 4a854475a0e6..82c492b05667 100644
--- a/sound/pci/hda/hda_auto_parser.c
+++ b/sound/pci/hda/hda_auto_parser.c
@@ -92,14 +92,10 @@ static int compare_input_type(const void *ap, const void *bp)
*/
static void reorder_outputs(unsigned int nums, hda_nid_t *pins)
{
- hda_nid_t nid;
-
switch (nums) {
case 3:
case 4:
- nid = pins[1];
- pins[1] = pins[2];
- pins[2] = nid;
+ swap(pins[1], pins[2]);
break;
}
}