diff options
| author |   Peter Ujfalusi <peter.ujfalusi@ti.com> | 2018-02-20 16:19:05 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2018-02-20 14:24:38 +0000 |
| commit | 5e558f8afaec8957932b1dbe5aeff800f9fc6957 (patch) | |
| tree | 8d40ed2e94e5cf5ff52c3633200133b34ae2f2a8 /sound | |
| parent | Linux 4.16-rc1 (diff) | |
| download | linux-dev-5e558f8afaec8957932b1dbe5aeff800f9fc6957.tar.xz linux-dev-5e558f8afaec8957932b1dbe5aeff800f9fc6957.zip | |
ASoC: hdmi-codec: Fix module unloading caused kernel crash
The hcp->chmap_info must not be freed up in the hdmi_codec_remove()
function as it leads to kernel crash due ALSA core's
pcm_chmap_ctl_private_free() is trying to free it up again when the card
destroyed via snd_card_free.
Commit cd6111b26280a ("ASoC: hdmi-codec: add channel mapping control")
should not have added the kfree(hcp->chmap_info); to the hdmi_codec_remove
function.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Jyri Sarha <jsarha@ti.com>
Tested-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/codecs/hdmi-codec.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index 5672e516bec3..c1830ccd3bb8 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -798,12 +798,7 @@ static int hdmi_codec_probe(struct platform_device *pdev) static int hdmi_codec_remove(struct platform_device *pdev) { - struct device *dev = &pdev->dev; - struct hdmi_codec_priv *hcp; - - hcp = dev_get_drvdata(dev); - kfree(hcp->chmap_info); - snd_soc_unregister_codec(dev); + snd_soc_unregister_codec(&pdev->dev); return 0; } |