diff options
| author |   Julia Lawall <Julia.Lawall@lip6.fr> | 2012-08-19 09:02:55 +0200 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2012-08-20 10:57:51 +0200 |
| commit | ae970eb45d8a1ea4506be23c3f776225b9575d0e (patch) | |
| tree | d810033861da7c505e7a837b52d069d87db7d025 /sound | |
| parent | ALSA: sound/pci/ctxfi/ctatc.c: fix error return code (diff) | |
| download | linux-dev-ae970eb45d8a1ea4506be23c3f776225b9575d0e.tar.xz linux-dev-ae970eb45d8a1ea4506be23c3f776225b9575d0e.zip | |
ALSA: sound/pci/sis7019.c: fix error return code
Initialize rc before returning on failure, as done elsewhere in the
function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/pci/sis7019.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sound/pci/sis7019.c b/sound/pci/sis7019.c index 512434efcc31..805ab6e9a78f 100644 --- a/sound/pci/sis7019.c +++ b/sound/pci/sis7019.c @@ -1377,8 +1377,9 @@ static int __devinit sis_chip_create(struct snd_card *card, if (rc) goto error_out_cleanup; - if (request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, - sis)) { + rc = request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, + sis); + if (rc) { dev_err(&pci->dev, "unable to allocate irq %d\n", sis->irq); goto error_out_cleanup; } |