diff options
| author |   Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-09 23:29:48 -0500 |
|---|---|---|
| committer |   Takashi Iwai <tiwai@suse.de> | 2019-08-10 09:57:22 +0200 |
| commit | cfef67f016e4c00a2f423256fc678a6967a9fc09 (patch) | |
| tree | 4c9319fe3f08a3ec3846a4b331f635481f6d1d0c /sound | |
| parent | ALSA: hda - Apply workaround for another AMD chip 1022:1487 (diff) | |
| download | linux-dev-cfef67f016e4c00a2f423256fc678a6967a9fc09.tar.xz linux-dev-cfef67f016e4c00a2f423256fc678a6967a9fc09.zip | |
ALSA: hda - Fix a memory leak bug
In snd_hda_parse_generic_codec(), 'spec' is allocated through kzalloc().
Then, the pin widgets in 'codec' are parsed. However, if the parsing
process fails, 'spec' is not deallocated, leading to a memory leak.
To fix the above issue, free 'spec' before returning the error.
Fixes: 352f7f914ebb ("ALSA: hda - Merge Realtek parser code to generic parser")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/pci/hda/hda_generic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index 485edaba0037..8f2beb1f3ae4 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -6100,7 +6100,7 @@ static int snd_hda_parse_generic_codec(struct hda_codec *codec) err = snd_hda_parse_pin_defcfg(codec, &spec->autocfg, NULL, 0); if (err < 0) - return err; + goto error; err = snd_hda_gen_parse_auto_config(codec, &spec->autocfg); if (err < 0) |