diff options
| author |   Codrin Ciubotariu <codrin.ciubotariu@microchip.com> | 2019-06-26 13:49:46 +0300 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2019-06-26 12:26:02 +0100 |
| commit | da7260cc8d1dc3564eb4f33550b0525541d71a47 (patch) | |
| tree | 1715d233d016eb5669cc77bb65ae98dfe68598c9 /sound | |
| parent | ASoC: dapm: Adapt for debugfs API change (diff) | |
| download | linux-dev-da7260cc8d1dc3564eb4f33550b0525541d71a47.tar.xz linux-dev-da7260cc8d1dc3564eb4f33550b0525541d71a47.zip | |
ASoC: codecs: ad193x: Fix memory corruption on BE 64b systems
Since change_bit() requires unsigned long*, making this cast on an
unsigned int variable will change a wrong bit on BE platforms, causing
memory corruption. Replace this function with a simple XOR.
Fixes: 90f6e6803139 ("ASoC: codecs: ad193x: Fix frame polarity for DSP_A format")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/codecs/ad193x.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/sound/soc/codecs/ad193x.c b/sound/soc/codecs/ad193x.c index 96d7cb2e4a56..16e2d334bbe0 100644 --- a/sound/soc/codecs/ad193x.c +++ b/sound/soc/codecs/ad193x.c @@ -241,10 +241,8 @@ static int ad193x_set_dai_fmt(struct snd_soc_dai *codec_dai, } /* For DSP_*, LRCLK's polarity must be inverted */ - if (fmt & SND_SOC_DAIFMT_DSP_A) { - change_bit(ffs(AD193X_DAC_LEFT_HIGH) - 1, - (unsigned long *)&dac_fmt); - } + if (fmt & SND_SOC_DAIFMT_DSP_A) + dac_fmt ^= AD193X_DAC_LEFT_HIGH; switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBM_CFM: /* codec clk & frm master */ |