diff options
| author |   Andrii Nakryiko <andrii@kernel.org> | 2021-04-23 11:13:40 -0700 |
|---|---|---|
| committer |   Alexei Starovoitov <ast@kernel.org> | 2021-04-23 14:05:27 -0700 |
| commit | 83a157279f2125ce1c4d6d93750440853746dff0 (patch) | |
| tree | 03c89c30dc6a6c409be6f0c73a4c0d6bcf019269 /tools/lib/bpf/linker.c | |
| parent | libbpf: Extend sanity checking ELF symbols with externs validation (diff) | |
| download | linux-dev-83a157279f2125ce1c4d6d93750440853746dff0.tar.xz linux-dev-83a157279f2125ce1c4d6d93750440853746dff0.zip | |
libbpf: Tighten BTF type ID rewriting with error checking
It should never fail, but if it does, it's better to know about this rather
than end up with nonsensical type IDs.
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/20210423181348.1801389-11-andrii@kernel.org
Diffstat (limited to 'tools/lib/bpf/linker.c')
| -rw-r--r-- | tools/lib/bpf/linker.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/tools/lib/bpf/linker.c b/tools/lib/bpf/linker.c index b0e038480300..5505c85e8b7b 100644 --- a/tools/lib/bpf/linker.c +++ b/tools/lib/bpf/linker.c @@ -1429,6 +1429,13 @@ static int linker_fixup_btf(struct src_obj *obj) static int remap_type_id(__u32 *type_id, void *ctx) { int *id_map = ctx; + int new_id = id_map[*type_id]; + + /* Error out if the type wasn't remapped. Ignore VOID which stays VOID. */ + if (new_id == 0 && *type_id != 0) { + pr_warn("failed to find new ID mapping for original BTF type ID %u\n", *type_id); + return -EINVAL; + } *type_id = id_map[*type_id]; |