diff options
| author |   Magnus Karlsson <magnus.karlsson@intel.com> | 2019-04-16 14:58:10 +0200 |
|---|---|---|
| committer |   Alexei Starovoitov <ast@kernel.org> | 2019-04-16 20:13:10 -0700 |
| commit | a06d729646e87afc5ce06e539aecf762cc26c6e3 (patch) | |
| tree | 1b45209f43dc48c5016a59d1e236bc74d6fb4331 /tools/lib/bpf | |
| parent | libbpf: fix XDP socket ring buffer memory ordering (diff) | |
| download | linux-dev-a06d729646e87afc5ce06e539aecf762cc26c6e3.tar.xz linux-dev-a06d729646e87afc5ce06e539aecf762cc26c6e3.zip | |
libbpf: remove likely/unlikely in xsk.h
This patch removes the use of likely and unlikely in xsk.h since they
create a dependency on Linux headers as reported by several
users. There have also been reports that the use of these decreases
performance as the compiler puts the code on two different cache lines
instead of on a single one. All in all, I think we are better off
without them.
Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets")
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'tools/lib/bpf')
| -rw-r--r-- | tools/lib/bpf/xsk.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/lib/bpf/xsk.h b/tools/lib/bpf/xsk.h index 1b35c40dff73..f264f24f06ac 100644 --- a/tools/lib/bpf/xsk.h +++ b/tools/lib/bpf/xsk.h @@ -109,7 +109,7 @@ static inline __u32 xsk_cons_nb_avail(struct xsk_ring_cons *r, __u32 nb) static inline size_t xsk_ring_prod__reserve(struct xsk_ring_prod *prod, size_t nb, __u32 *idx) { - if (unlikely(xsk_prod_nb_free(prod, nb) < nb)) + if (xsk_prod_nb_free(prod, nb) < nb) return 0; *idx = prod->cached_prod; @@ -133,7 +133,7 @@ static inline size_t xsk_ring_cons__peek(struct xsk_ring_cons *cons, { size_t entries = xsk_cons_nb_avail(cons, nb); - if (likely(entries > 0)) { + if (entries > 0) { /* Make sure we do not speculatively read the data before * we have received the packet buffers from the ring. */ |