aboutsummaryrefslogtreecommitdiffstats
path: root/tools/memory-model
diff options
context:
space:
mode:
authorMatthew Wilcox <willy@infradead.org>2018-08-20 10:19:14 -0400
committerIngo Molnar <mingo@kernel.org>2018-10-02 09:49:42 +0200
commit27df89689e257cccb604fdf56c91a75a25aa554a (patch)
tree783e97bf76ae8c269f28e59f21ec62c6dc3dfa3f /tools/memory-model
parentlocking/lockdep, cpu/hotplug: Annotate AP thread (diff)
downloadlinux-dev-27df89689e257cccb604fdf56c91a75a25aa554a.tar.xz
linux-dev-27df89689e257cccb604fdf56c91a75a25aa554a.zip
locking/spinlocks: Remove an instruction from spin and write locks
Both spin locks and write locks currently do: f0 0f b1 17 lock cmpxchg %edx,(%rdi) 85 c0 test %eax,%eax 75 05 jne [slowpath] This 'test' insn is superfluous; the cmpxchg insn sets the Z flag appropriately. Peter pointed out that using atomic_try_cmpxchg_acquire() will let the compiler know this is true. Comparing before/after disassemblies show the only effect is to remove this insn. Take this opportunity to make the spin & write lock code resemble each other more closely and have similar likely() hints. Suggested-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Matthew Wilcox <willy@infradead.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Will Deacon <will.deacon@arm.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Waiman Long <longman@redhat.com> Link: http://lkml.kernel.org/r/20180820162639.GC25153@bombadil.infradead.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools/memory-model')
0 files changed, 0 insertions, 0 deletions