IB/{hfi1, qib}: Fix a concurrency issue with device name in logging - linux-dev - Linux kernel development work

diff options

author	Michael J. Ruhl <michael.j.ruhl@intel.com>	2017-12-18 19:57:21 -0800
committer	Doug Ledford <dledford@redhat.com>	2018-01-05 13:34:55 -0500
commit	11f0e89710ebea7d1086cbe9ab1270c96677f1dc (patch)
tree	dc9152e3cbb4a42a41684cdf74b3654bf361c2cb /tools/perf/scripts/python/bin
parent	IB/rdmavt: Allocate CQ memory on the correct node (diff)

IB/{hfi1, qib}: Fix a concurrency issue with device name in logging

The get_unit_name() function crafts a string based on the device name and the device unit number. It then stores this in a static variable. This has concurrency issues as can be seen with this log: hfi1 0000:02:00.0: hfi1_1: read_idle_message: read idle message 0x203 hfi1 0000:01:00.0: hfi1_1: read_idle_message: read idle message 0x203 The PCI device ID (0000:02:00.0 vs. 0000:01:00.0) is correct for the message, but the device string hfi1_1 is incorrect (it should be hfi1_0 for the second log message). Remove get_unit_name() function. Instead, use the rvt accessor rvt_get_ibdev_name() to get the IB name string. Clean up any hfi1_early_xx calls that can now use the new path. QIB has the same (qib_get_unit_name()) issue. Updating as necessary. Remove qib_get_unit_name() function. Update log message that has redundant device name. Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by: Doug Ledford <dledford@redhat.com>

Diffstat (limited to 'tools/perf/scripts/python/bin')

0 files changed, 0 insertions, 0 deletions

/* Copyright (C) 1991-2013 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. The GNU C Library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with the GNU C Library; if not, see <http://www.gnu.org/licenses/>. */ #ifdef HAVE_CONFIG_H # include <config.h> #endif #include <ctype.h> #include <string.h> #ifndef _LIBC # define __strcasecmp strcasecmp # define TOLOWER(Ch) tolower (Ch) #else # include <locale/localeinfo.h> # ifdef USE_IN_EXTENDED_LOCALE_MODEL # define __strcasecmp __strcasecmp_l # endif # define TOLOWER(Ch) __tolower_l ((Ch), loc) #endif #ifdef USE_IN_EXTENDED_LOCALE_MODEL # define LOCALE_PARAM , loc # define LOCALE_PARAM_DECL __locale_t loc; #else # define LOCALE_PARAM # define LOCALE_PARAM_DECL #endif /* Compare S1 and S2, ignoring case, returning less than, equal to or greater than zero if S1 is lexicographically less than, equal to or greater than S2. */ int __strcasecmp (s1, s2 LOCALE_PARAM) const char *s1; const char *s2; LOCALE_PARAM_DECL { #if defined _LIBC && !defined USE_IN_EXTENDED_LOCALE_MODEL __locale_t loc = _NL_CURRENT_LOCALE; #endif const unsigned char *p1 = (const unsigned char *) s1; const unsigned char *p2 = (const unsigned char *) s2; int result; if (p1 == p2) return 0; while ((result = TOLOWER (*p1) - TOLOWER (*p2++)) == 0) if (*p1++ == '\0') break; return result; } #ifndef __strcasecmp libc_hidden_def (__strcasecmp) weak_alias (__strcasecmp, strcasecmp) #endif


context:
space:
mode: