diff options
| author |   Michael Ellerman <mpe@ellerman.id.au> | 2016-10-28 17:39:53 +1100 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2016-11-18 23:02:19 +1100 |
| commit | e9eb0278dad9c7a2631d5432180a130710110c09 (patch) | |
| tree | 837a2226a78607735c11eb06b3ee030709fe3385 /tools/perf/scripts/python/call-graph-from-postgresql.py | |
| parent | powerpc/configs: Turn on PPC crypto implementations in the server defconfigs (diff) | |
| download | linux-dev-e9eb0278dad9c7a2631d5432180a130710110c09.tar.xz linux-dev-e9eb0278dad9c7a2631d5432180a130710110c09.zip | |
powerpc/64: Used named initialisers for ibm_pa_features
The ibm_pa_features array consists of structures that describe which bit
and byte in the ibm,pa-features property toggles one or more flags in
either the CPU, MMU, or user visible feature flags.
Each one consists of 7 values, which are all unsigned long, int or char,
meaning the compiler gives us no warning if we assign the wrong values
to the wrong elements. In fact we have had a bug here in the past, where
we were setting incorrect bits, see commit 6997e57d693b ("powerpc:
scan_features() updates incorrect bits for REAL_LE").
So switch to using named initialisers for the structure elements, to
reduce the likelihood of future bugs, and hopefully improve readability
also.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Balbir Singh <bsingharora@gmail.com>
Diffstat (limited to 'tools/perf/scripts/python/call-graph-from-postgresql.py')
0 files changed, 0 insertions, 0 deletions