diff options
author | 2020-11-19 08:50:19 +0900 | |
---|---|---|
committer | 2020-11-26 13:09:37 +0000 | |
commit | 453d32c2f7f7375c223eaf3a0a32efbb71bbd3f3 (patch) | |
tree | 2231ca785eadae93f1f574e16300f21655d592e9 /tools/perf/scripts/python/export-to-postgresql.py | |
parent | ASoC: soc-component: add mark for snd_soc_link_compr_startup/shutdown() (diff) | |
download | linux-dev-453d32c2f7f7375c223eaf3a0a32efbb71bbd3f3.tar.xz linux-dev-453d32c2f7f7375c223eaf3a0a32efbb71bbd3f3.zip |
ASoC: soc-compress: add soc_compr_clean() and call it from soc_compr_open/free()
soc_compr_open() does rollback when failed (A),
but, it is almost same as soc_compr_free().
static int soc_compr_open(xxx)
{
...
if (ret < 0)
goto xxx_err;
...
return 0;
^ machine_err:
| ...
| out:
(A) ...
| pm_err:
| ...
v return ret;
}
The difference is
soc_compr_free() is for all dai/component/substream,
rollback is for succeeded part only.
This kind of duplicated code can be a hotbed of bugs,
thus, we want to share soc_compr_free() and rollback.
Now, soc_compr_open/free() are handling
1) snd_soc_dai_compr_startup/shutdown()
2) snd_soc_component_compr_open/free()
3) snd_soc_link_compr_startup/shutdown()
Now, 1) to 3) are handled.
This patch adds new soc_compr_clean() and call it from
soc_compr_open() as rollback, and from soc_compr_free_free() as
normal close handler.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87ima25iwa.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions