diff options
author | 2022-02-22 16:27:07 -0800 | |
---|---|---|
committer | 2022-03-15 13:22:54 -0700 | |
commit | 7eb517e434c653a4afa16ec3d0a750c2f46b3560 (patch) | |
tree | 3ec32b3684310d6ba0ee4204f79e16acca3dae9a /tools/perf/scripts/python/export-to-postgresql.py | |
parent | ice: convert ice_reset_vf to standard error codes (diff) | |
download | linux-dev-7eb517e434c653a4afa16ec3d0a750c2f46b3560.tar.xz linux-dev-7eb517e434c653a4afa16ec3d0a750c2f46b3560.zip |
ice: convert ice_reset_vf to take flags
The ice_reset_vf function takes a boolean parameter which indicates
whether or not the reset is due to a VFLR event.
This is somewhat confusing to read because readers must interpret what
"true" and "false" mean when seeing a line of code like
"ice_reset_vf(vf, false)".
We will want to add another toggle to the ice_reset_vf in a following
change. To avoid proliferating many arguments, convert this function to
take flags instead. ICE_VF_RESET_VFLR will indicate if this is a VFLR
reset. A value of 0 indicates no flags.
One could argue that "ice_reset_vf(vf, 0)" is no more readable than
"ice_reset_vf(vf, false)".. However, this type of flags interface is
somewhat common and using 0 to mean "no flags" makes sense in this
context. We could bother to add a define for "ICE_VF_RESET_PLAIN" or
something similar, but this can be confusing since its not an actual bit
flag.
This paves the way to add another flag to the function in a following
change.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions