diff options
author | 2016-10-28 12:27:26 -0400 | |
---|---|---|
committer | 2016-11-01 13:31:23 -0400 | |
commit | aac173e9618faadf8f92af6cc05e64f7acc64d79 (patch) | |
tree | 2b1145a0b142843a566dac4221bf9e385896bc44 /tools/perf/scripts/python/export-to-postgresql.py | |
parent | scsi: mpt3sas: Fix for block device of raid exists even after deleting raid disk (diff) | |
download | linux-dev-aac173e9618faadf8f92af6cc05e64f7acc64d79.tar.xz linux-dev-aac173e9618faadf8f92af6cc05e64f7acc64d79.zip |
scsi: vmw_pvscsi: return SUCCESS for successful command aborts
The vmw_pvscsi driver reports most successful aborts as FAILED to the
scsi error handler. This is do to a misunderstanding of how
completion_done() works and its interaction with a successful wait using
wait_for_completion_timeout(). The vmw_pvscsi driver is expecting
completion_done() to always return true if complete() has been called on
the completion structure. But completion_done() returns true after
complete() has been called only if no function like
wait_for_completion_timeout() has seen the completion and cleared it as
part of successfully waiting for the completion.
Instead of using completion_done(), vmw_pvscsi should just use the
return value from wait_for_completion_timeout() to know if the wait
timed out or not.
[mkp: bumped driver version per request]
Signed-off-by: David Jeffery <djeffery@redhat.com>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Acked-by: Jim Gill <jgill@vmware.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions