diff options
author | 2022-08-11 20:00:21 -0500 | |
---|---|---|
committer | 2022-09-06 22:05:58 -0400 | |
commit | beb4dac8d23546c14c77fce724a214348523d503 (patch) | |
tree | 085fabc762f890a6c9951002c4bb5cb3ee8e8bbe /tools/perf/scripts/python/export-to-postgresql.py | |
parent | scsi: uas: Drop DID_TARGET_FAILURE use (diff) | |
download | linux-dev-beb4dac8d23546c14c77fce724a214348523d503.tar.xz linux-dev-beb4dac8d23546c14c77fce724a214348523d503.zip |
scsi: virtio_scsi: Drop DID_TARGET_FAILURE use
DID_TARGET_FAILURE is internal to the SCSI layer. Drivers must not use it
because:
1. It's not propagated upwards, so SG IO/passthrough users will not see an
error and think a command was successful.
2. There is no handling for it in scsi_decide_disposition() so it results
in entering SCSI error handling.
virtio_scsi gets this when something like qemu returns
VIRTIO_SCSI_S_TARGET_FAILURE. It looks like qemu returns that error code
if a host OS returns it, but this shouldn't happen for Linux since we never
propagate that error to userspace.
This has us use DID_BAD_TARGET in case some other virt layer is returning
it. In that case we will still get a hard error like before and it conveys
something unexpected happened.
Link: https://lore.kernel.org/r/20220812010027.8251-5-michael.christie@oracle.com
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions