diff options
| author |   Xin Xiong <xiongx18@fudan.edu.cn> | 2022-08-10 23:29:13 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-08-12 11:21:28 +0100 |
| commit | bfc48f1b0505ffcb03a6d749139b7577d6b81ae0 (patch) | |
| tree | 02acba0b72a6045625b6111c25b47642039af5e1 /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | skfp/h: fix repeated words in comments (diff) | |
| download | linux-dev-bfc48f1b0505ffcb03a6d749139b7577d6b81ae0.tar.xz linux-dev-bfc48f1b0505ffcb03a6d749139b7577d6b81ae0.zip | |
net/sunrpc: fix potential memory leaks in rpc_sysfs_xprt_state_change()
The issue happens on some error handling paths. When the function
fails to grab the object `xprt`, it simply returns 0, forgetting to
decrease the reference count of another object `xps`, which is
increased by rpc_sysfs_xprt_kobj_get_xprt_switch(), causing refcount
leaks. Also, the function forgets to check whether `xps` is valid
before using it, which may result in NULL-dereferencing issues.
Fix it by adding proper error handling code when either `xprt` or
`xps` is NULL.
Fixes: 5b7eb78486cd ("SUNRPC: take a xprt offline using sysfs")
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions