diff options
| author |   Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2021-11-11 11:56:29 +0100 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-11-30 12:07:36 +0100 |
| commit | 89ab2d39643e5ce2b122baa1e76176d1bd984cec (patch) | |
| tree | 87c7a55e7d9a965ba12a67b332963f2cf74d7168 /tools/perf/scripts/python/stackcollapse.py | |
| parent | media: s5c73m3: Drop empty spi_driver remove callback (diff) | |
media: vb2: frame_vector.c: don't overwrite error code
get_vaddr_frames() first calls pin_user_pages_fast() and if
that fails tries follow_pfn(). But if that also fails, then
the error code from pin_user_pages_fast() is overwritten with
the error code from follow_pfn().
Specifically if pin_user_pages_fast() returns -ENOMEM, then
follow_pfn() will overwrite that with -EINVAL, which is very
confusing.
So store the error code from pin_user_pages_fast() and return
that if follow_pfn() returns -EINVAL. -EINVAL indicates that
the page is unsuitable for follow_pfn, so pin_user_pages_fast()
was the correct call to make, and that error code should be
returned instead.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions