diff options
author | 2013-05-30 09:59:39 -0600 | |
---|---|---|
committer | 2013-06-01 19:46:16 +0100 | |
commit | 4dd9572abc224019a042b662fb0eececca283cb9 (patch) | |
tree | 920636df3ca9198c43fd89973703b6e177cb27cc /tools/perf/scripts/python/syscall-counts.py | |
parent | spi: spi-imx: Fix compilation error (diff) | |
download | linux-dev-4dd9572abc224019a042b662fb0eececca283cb9.tar.xz linux-dev-4dd9572abc224019a042b662fb0eececca283cb9.zip |
spi: fix undefined behaviour in SPI_BPW_RANGE_MASK
The parameters to SPI_BPW_RANGE_MASK() are in the range 1..32. If 32 is
used as a parameter, part of the expression is "1 << 32". Since 32 is >=
the size of the type in use, such a shift is undefined behaviour. Add
macro SPI_BIT_MASK to Implement a special case and thus avoid undefined
behaviour. Use this new macro rather than BIT() when implementing
SPI_BPW_RANGE_MASK().
This fixes build warnings such as:
drivers/spi/spi-gpio.c:446:2: warning: left shift count >= width of type [enabled by default]
SPI_BPW_MASK() already avoids this, since its parameter is also in range
1..32, yet it only shifts by up to one less than the input parameter.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts.py')
0 files changed, 0 insertions, 0 deletions