diff options
author | 2012-05-21 20:55:40 +0800 | |
---|---|---|
committer | 2012-06-04 10:42:49 +0100 | |
commit | c71c8fd4daa342ba714090586a55fc5db7eaa275 (patch) | |
tree | 3ea2ed05648bb232fa123923b666580621b8978e /tools/perf/scripts/python/syscall-counts.py | |
parent | Linux 3.5-rc1 (diff) | |
download | linux-dev-c71c8fd4daa342ba714090586a55fc5db7eaa275.tar.xz linux-dev-c71c8fd4daa342ba714090586a55fc5db7eaa275.zip |
regulator: palmas: Fix wrong kfree calls
The devm_kzalloc function eliminates the need for manual resource releasing
and simplify error handling. Resources allocated by devm_* are freed
automatically on driver detach.
Thus adding kfree calls here will introduce double free bug.
The memory of desc array and the pointers to the rdev[] are allocated by
devm_kzalloc call for struct palmas_pmic.
struct palmas_pmic {
struct palmas *palmas;
struct device *dev;
struct regulator_desc desc[PALMAS_NUM_REGS];
struct regulator_dev *rdev[PALMAS_NUM_REGS];
struct mutex mutex;
int smps123;
int smps457;
int range[PALMAS_REG_SMPS10];
};
Which means we should not call kfree for pmic->rdev and pmic->desc.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts.py')
0 files changed, 0 insertions, 0 deletions