aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/util/annotate.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2012-04-19 10:16:27 -0300
committerArnaldo Carvalho de Melo <acme@redhat.com>2012-04-19 10:16:27 -0300
commit28548d78ad521310f0ae58f791aa796d3d685151 (patch)
tree381d507e987faec4e1628fecf588c85987adaa35 /tools/perf/util/annotate.c
parentperf annotate: Parse call targets earlier (diff)
downloadlinux-dev-28548d78ad521310f0ae58f791aa796d3d685151.tar.xz
linux-dev-28548d78ad521310f0ae58f791aa796d3d685151.zip
perf annotate: Introduce scnprintf ins_ops method
And implement the jump one, where if the operands string is not passed, a compact form that uses just the target address is used. Right now this is toggled via the 'o' option in the annotate browser, switching from: 0.00 : ffffffff811661e8: je ffffffff81166204 <mem_cgroup_count_vm_event+0x44> 0.00 : ffffffff811661ea: cmp $0xb,%esi 0.00 : ffffffff811661ed: je ffffffff811661f8 <mem_cgroup_count_vm_event+0x38> To: 0.00 : 28: je 44 0.00 : 2a: cmp $0xb,%esi 0.00 : 2d: je 38 Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-o88q46yh4kxgpd1chk5gvjl5@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/annotate.c')
-rw-r--r--tools/perf/util/annotate.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index a4296fdd9a68..ed1f89d7044e 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -44,8 +44,18 @@ static int jump_ops__parse_target(const char *operands, u64 *target)
return 0;
}
+static int jump_ops__scnprintf(struct ins *ins, char *bf, size_t size,
+ const char *operands, u64 target)
+{
+ if (operands)
+ return scnprintf(bf, size, "%-6.6s %s", ins->name, operands);
+
+ return scnprintf(bf, size, "%-6.6s %" PRIx64, ins->name, target);
+}
+
static struct ins_ops jump_ops = {
.parse_target = jump_ops__parse_target,
+ .scnprintf = jump_ops__scnprintf,
};
bool ins__is_jump(const struct ins *ins)