aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/util/cpumap.c
diff options
context:
space:
mode:
authorMark Rutland <mark.rutland@arm.com>2016-07-15 11:08:10 +0100
committerArnaldo Carvalho de Melo <acme@redhat.com>2016-07-18 19:41:14 -0300
commit00e727bb389359c81101b03d34fec8cc7be5168d (patch)
tree93f2d7b207e4eeec77501a02bd9f721a14edb5a8 /tools/perf/util/cpumap.c
parenttools: Copy linux/{hash,poison}.h and check for drift (diff)
downloadlinux-dev-00e727bb389359c81101b03d34fec8cc7be5168d.tar.xz
linux-dev-00e727bb389359c81101b03d34fec8cc7be5168d.zip
perf stat: Balance opening and reading events
In create_perf_stat_counter, when a target CPU has not been provided, we call __perf_evsel__open with empty_cpu_map, and open a single FD per thread. However, in read_counter we assume that we opened events for the product of threads and CPUs described in the evsel's cpu_map. Thus, if an evsel has a cpu_map with more than one entry, we will attempt to access FDs that we didn't open. This could result in a number of problems (e.g. blocking while reading from STDIN if the fd memory happened to be initialised to zero). This is problematic for systems were a logical CPU PMU covers some arbitrary subset of CPUs. The cpu_map of any evsel for that PMU will be initialised based on the cpumask exposed through sysfs, even if the user requests per-thread events. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: He Kuang <hekuang@huawei.com> Cc: Kan Liang <kan.liang@intel.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/r/1468577293-19667-2-git-send-email-mark.rutland@arm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/cpumap.c')
0 files changed, 0 insertions, 0 deletions