diff options
| author |   Josh Poimboeuf <jpoimboe@redhat.com> | 2015-12-07 22:21:46 -0600 |
|---|---|---|
| committer |   Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-12-09 13:42:03 -0300 |
| commit | 2bdb2c2729d2ba2f2f90b729d04254308096c5a0 (patch) | |
| tree | fd865389ddfa21385c2a72180696f36e5bf23301 /tools/perf/util/env.c | |
| parent | perf tools: Move term functions out of util.c (diff) | |
| download | linux-dev-2bdb2c2729d2ba2f2f90b729d04254308096c5a0.tar.xz linux-dev-2bdb2c2729d2ba2f2f90b729d04254308096c5a0.zip | |
perf tools: Save cmdline arguments earlier
perf_env__set_cmdline() only saves the arguments the first time it's
called. It doesn't need to be called every time the options and
suboptions are parsed. Instead it can just be called once.
This also has the advantage of making the option parsing code less
perf-specific so it can be moved out to a library.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/19b76a5aa1b688bd635bd65d80bbc103a978d75e.1449548395.git.jpoimboe@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/env.c')
| -rw-r--r-- | tools/perf/util/env.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/tools/perf/util/env.c b/tools/perf/util/env.c index 6af4f7c36820..7dd5939dea2e 100644 --- a/tools/perf/util/env.c +++ b/tools/perf/util/env.c @@ -25,15 +25,6 @@ int perf_env__set_cmdline(struct perf_env *env, int argc, const char *argv[]) { int i; - /* - * If env->cmdline_argv has already been set, do not override it. This allows - * a command to set the cmdline, parse args and then call another - * builtin function that implements a command -- e.g, cmd_kvm calling - * cmd_record. - */ - if (env->cmdline_argv != NULL) - return 0; - /* do not include NULL termination */ env->cmdline_argv = calloc(argc, sizeof(char *)); if (env->cmdline_argv == NULL) |