diff options
| author |   Thomas Jarosch <thomas.jarosch@intra2net.com> | 2013-01-25 11:21:39 +0100 |
|---|---|---|
| committer |   Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-01-30 10:40:18 -0300 |
| commit | fdae6373910c10e27b8ae07e11e821b183d0bba5 (patch) | |
| tree | 6faa0035aa4c58f2aff9eb7d6e8191292d1e01d0 /tools/perf/util/header.c | |
| parent | perf tools: Fix memory leak on error (diff) | |
| download | linux-dev-fdae6373910c10e27b8ae07e11e821b183d0bba5.tar.xz linux-dev-fdae6373910c10e27b8ae07e11e821b183d0bba5.zip | |
perf header: Fix memory leak for the "Not caching a kptr_restrict'ed /proc/kallsyms" case
cppcheck reported:
[util/header.c:316]: (error) Memory leak: filename
[util/header.c:316]: (error) Memory leak: linkname
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Link: http://lkml.kernel.org/r/9377388.0eFDp53iW6@storm
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/header.c')
| -rw-r--r-- | tools/perf/util/header.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index e17a8fe9c4d7..7b24cf3237d8 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -313,7 +313,8 @@ int build_id_cache__add_s(const char *sbuild_id, const char *debugdir, if (is_kallsyms) { if (symbol_conf.kptr_restrict) { pr_debug("Not caching a kptr_restrict'ed /proc/kallsyms\n"); - return 0; + err = 0; + goto out_free; } realname = (char *) name; } else |