diff options
| author |   Jiri Olsa <jolsa@redhat.com> | 2011-03-07 21:13:40 +0100 |
|---|---|---|
| committer |   Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-03-10 10:54:13 -0300 |
| commit | b9a46bba88001504235459c8410f17e6a7e38008 (patch) | |
| tree | 35687cc87135475ce5be257c878cee6eeaf40f37 /tools/perf/util/header.h | |
| parent | kprobes: Disabling optimized kprobes for entry text section (diff) | |
| download | linux-dev-b9a46bba88001504235459c8410f17e6a7e38008.tar.xz linux-dev-b9a46bba88001504235459c8410f17e6a7e38008.zip | |
perf top: Fix events overflow in top command
The snprintf function returns number of printed characters even if it
cross the size parameter. So passing enough events via '-e' parameter
will cause segmentation fault.
It's reproduced by following command:
perf top -e `perf list | grep Tracepoint | awk -F'[' '\
{gsub(/[[:space:]]+/,"",$1);array[FNR]=$1}END{outputs=array[1];\
for (i=2;i<=FNR;i++){ outputs=outputs "," array[i];};print outputs}'`
Attached patch is adding SNPRINTF macro that provides the overflow check
and returns actuall number of printed characters.
Reported-by: Han Pingtian <phan@redhat.com>
Cc: Han Pingtian <phan@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1299528821-17521-2-git-send-email-jolsa@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/header.h')
0 files changed, 0 insertions, 0 deletions