diff options
| author |   Tianchen Ding <dtcccc@linux.alibaba.com> | 2022-06-09 07:34:11 +0800 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2022-06-13 10:30:01 +0200 |
| commit | 28156108fecb1f808b21d216e8ea8f0d205a530c (patch) | |
| tree | 00eeddc6d084d0059f632d9c7b7bebb4ace1839c /tools/perf/util/include/linux/git:/ssh:/git@git.zx2c4.com | |
| parent | sched: Allow newidle balancing to bail out of load_balance (diff) | |
| download | linux-dev-28156108fecb1f808b21d216e8ea8f0d205a530c.tar.xz linux-dev-28156108fecb1f808b21d216e8ea8f0d205a530c.zip | |
sched: Fix the check of nr_running at queue wakelist
The commit 2ebb17717550 ("sched/core: Offload wakee task activation if it
the wakee is descheduling") checked rq->nr_running <= 1 to avoid task
stacking when WF_ON_CPU.
Per the ordering of writes to p->on_rq and p->on_cpu, observing p->on_cpu
(WF_ON_CPU) in ttwu_queue_cond() implies !p->on_rq, IOW p has gone through
the deactivate_task() in __schedule(), thus p has been accounted out of
rq->nr_running. As such, the task being the only runnable task on the rq
implies reading rq->nr_running == 0 at that point.
The benchmark result is in [1].
[1] https://lore.kernel.org/all/e34de686-4e85-bde1-9f3c-9bbc86b38627@linux.alibaba.com/
Suggested-by: Valentin Schneider <vschneid@redhat.com>
Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Link: https://lore.kernel.org/r/20220608233412.327341-2-dtcccc@linux.alibaba.com
Diffstat (limited to 'tools/perf/util/include/linux/git:/ssh:/git@git.zx2c4.com')
0 files changed, 0 insertions, 0 deletions