aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/util/topdown.c
diff options
context:
space:
mode:
authorKan Liang <kan.liang@linux.intel.com>2020-09-11 07:48:06 -0700
committerArnaldo Carvalho de Melo <acme@redhat.com>2020-09-17 15:47:58 -0300
commitacb65150a47c2baea5ea02fd7cb66460f7733fcd (patch)
tree24c12e631c87b12a859971f5ad7ed2ddda569628 /tools/perf/util/topdown.c
parentperf tools: Rename group to topdown (diff)
downloadlinux-dev-acb65150a47c2baea5ea02fd7cb66460f7733fcd.tar.xz
linux-dev-acb65150a47c2baea5ea02fd7cb66460f7733fcd.zip
perf record: Support sample-read topdown metric group
With the hardware TopDown metrics feature, sample-read feature should be supported for a topdown group, e.g., sample a non-topdown event and read a topdown metric group. But the current perf record code errors out. For a topdown metric group, the slots event must be the leader of the group, but the leader slots event doesn't support sampling. To support sample-read the topdown metric group, use the 2nd event of the group as the "leader" for the purposes of sampling. Only the platform with Topdown metic feature supports sample-read the topdown group. Add arch_topdown_sample_read() to indicate whether the topdown group supports sample-read. Signed-off-by: Kan Liang <kan.liang@linux.intel.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Andi Kleen <ak@linux.intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lore.kernel.org/lkml/20200911144808.27603-3-kan.liang@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/topdown.c')
-rw-r--r--tools/perf/util/topdown.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/tools/perf/util/topdown.c b/tools/perf/util/topdown.c
index a085b3c77c27..1081b20f9891 100644
--- a/tools/perf/util/topdown.c
+++ b/tools/perf/util/topdown.c
@@ -51,3 +51,8 @@ __weak bool arch_topdown_check_group(bool *warn)
__weak void arch_topdown_group_warn(void)
{
}
+
+__weak bool arch_topdown_sample_read(struct evsel *leader __maybe_unused)
+{
+ return false;
+}