diff options
| author |   Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-07-29 11:54:35 -0300 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-07-29 11:54:35 -0300 |
| commit | ce92834407a465c25c0be1a4a0339c625e44c4db (patch) | |
| tree | 9e92abb0502396934f714b404f13f15d1cceba38 /tools/perf | |
| parent | perf annotate: Use pipe + fork instead of popen (diff) | |
| download | linux-dev-ce92834407a465c25c0be1a4a0339c625e44c4db.tar.xz linux-dev-ce92834407a465c25c0be1a4a0339c625e44c4db.zip | |
perf target: str_error_r() always returns the buffer it receives
So no need for checking if it uses the strerror_r() GNU variant error
reporting mechanism, i.e. if it returns a pointer to a immutable string
internal to glibc.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: c8b5f2c96d1b ("tools: Introduce str_error_r()")
Link: http://lkml.kernel.org/n/tip-xr83cd4y4r3cn6tq6w4f59jb@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
| -rw-r--r-- | tools/perf/util/target.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/tools/perf/util/target.c b/tools/perf/util/target.c index 8cdcf4641c51..21c4d9b23c24 100644 --- a/tools/perf/util/target.c +++ b/tools/perf/util/target.c @@ -122,11 +122,7 @@ int target__strerror(struct target *target, int errnum, BUG_ON(buflen == 0); if (errnum >= 0) { - const char *err = str_error_r(errnum, buf, buflen); - - if (err != buf) - scnprintf(buf, buflen, "%s", err); - + str_error_r(errnum, buf, buflen); return 0; } |