diff options
| author |   Brahadambal Srinivasan <latha@linux.vnet.ibm.com> | 2020-10-23 20:55:27 +0530 |
|---|---|---|
| committer |   Shuah Khan <skhan@linuxfoundation.org> | 2020-10-26 13:36:24 -0600 |
| commit | 748f0d70087c56226bf1df1f91a00b7ab4c8f883 (patch) | |
| tree | 8b9c94c478ebd88016e402cadb505a14fa9ca77d /tools/power/cpupower/utils/cpuidle-set.c | |
| parent | Linux 5.10-rc1 (diff) | |
| download | linux-dev-748f0d70087c56226bf1df1f91a00b7ab4c8f883.tar.xz linux-dev-748f0d70087c56226bf1df1f91a00b7ab4c8f883.zip | |
cpupower: Provide online and offline CPU information
When a user tries to modify cpuidle or cpufreq properties on offline
CPUs, the tool returns success (exit status 0) but also does not provide
any warning message regarding offline cpus that may have been specified
but left unchanged. In case of all or a few CPUs being offline, it can be
difficult to keep track of which CPUs didn't get the new frequency or idle
state set. Silent failures are difficult to keep track of when there are a
huge number of CPUs on which the action is performed.
This patch adds helper functions to find both online and offline CPUs and
print them out accordingly.
We use these helper functions in cpuidle-set and cpufreq-set to print an
additional message if the user attempts to modify offline cpus.
Reported-by: Pavithra R. Prakash <pavrampu@in.ibm.com>
Signed-off-by: Brahadambal Srinivasan <latha@linux.vnet.ibm.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/power/cpupower/utils/cpuidle-set.c')
| -rw-r--r-- | tools/power/cpupower/utils/cpuidle-set.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/power/cpupower/utils/cpuidle-set.c b/tools/power/cpupower/utils/cpuidle-set.c index 569f268f4c7f..46158928f9ad 100644 --- a/tools/power/cpupower/utils/cpuidle-set.c +++ b/tools/power/cpupower/utils/cpuidle-set.c @@ -95,6 +95,8 @@ int cmd_idle_set(int argc, char **argv) exit(EXIT_FAILURE); } + get_cpustate(); + /* Default is: set all CPUs */ if (bitmask_isallclear(cpus_chosen)) bitmask_setall(cpus_chosen); @@ -181,5 +183,7 @@ int cmd_idle_set(int argc, char **argv) break; } } + + print_offline_cpus(); return EXIT_SUCCESS; } |